[WIP] Introduce recursive events: events can now be triggered from within modules #3621
+59
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3621 +/- ##
=================================================
- Coverage 30.64% 30.60% -0.05%
- Complexity 15876 15927 +51
=================================================
Files 427 429 +2
Lines 74288 74311 +23
=================================================
- Hits 22768 22745 -23
- Misses 51520 51566 +46
Continue to review full report at Codecov.
|
|
I think this is very cool .... When I was first playing with the micro data I was thinking it would be nice if I could trigger an event from the code ! |
|
Spuds wrote on 3/29/22 12:31 AM:
I think this is very cool .... When I was first playing with the micro
data I was thinking it would be nice if I could trigger an event from
the code !
Little question: while working on this, I assumed that the trigger in
the addon, should pass the states of the addon itself, not those of the
controller, reason is the "addon of the addon" should be extending the
addon and not the controller, otherwise it should hook up into the
controller itself.
@Spuds do you think the reasoning works or should it always pass the
states and variables of the controller?
|
|
I think that makes sense, I'd be able to give a better answer if (when) I work on an addon that utilizes the functionality, but rolling it around in my head extending the addon seems proper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Spuds there we go: recursive events... actually probably it would have been better to call them nested? Yeah. Whatever.
I thought thi was going to solve the issue with attachments you were facing, but it doesn't, though it looks pretty cool to me, so I just pushed it... let me know what you think. 😆